Sleep less time but try more times when stopping#112
Merged
roryqi merged 1 commit intoapache:masterfrom Jul 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=========================================
Coverage 56.52% 56.52%
Complexity 1183 1183
=========================================
Files 149 149
Lines 8019 8019
Branches 767 767
=========================================
Hits 4533 4533
Misses 3242 3242
Partials 244 244 Help us with your feedback. Take ten seconds to tell us how you rate us. |
roryqi
approved these changes
Jul 30, 2022
Contributor
roryqi
left a comment
roryqi
left a comment
There was a problem hiding this comment.
Good catch! Thanks @xianjingfeng LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sleep less time but try more times when stopping
Why are the changes needed?
Waiting time for executing stop script is too long even if the JVM exits early.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Have already verify in our production enviroment.